Add a PadnameREFCNT_inc() macro #20107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmari
approved these changes
Aug 17, 2022
Implemented as a static inline function call, so that it can return the padname pointer itself. This would allow use in expressions such as ptr->field = PadnameREFCNT_inc(pn); That makes it similar to the familiar SvREFCNT_inc() macro.
leonerd
force-pushed
the
PadnameREFCNT_inc
branch
from
afddd67
to
a6a670e
Compare
leonerd
commented
Aug 17, 2022
| @@ -3430,6 +3430,13 @@ Perl_cop_file_avn(pTHX_ const COP *cop) { | |||
|
|
|||
| #endif | |||
|
|
|||
| PERL_STATIC_INLINE PADNAME * | |||
| Perl_padname_refcnt_inc(PADNAME *pn) | |||
There was a problem hiding this comment.
Sudden wondering whether this should be named S_ instead of Perl_, as it's only here to make one of the macros work.
There was a problem hiding this comment.
Eh; most of the rest of them are Perl_... and those seem fine. I'll leave it as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented as a static inline function call, so that it can return the padname pointer itself. This would allow use in expressions such as
That makes it similar to the familiar
SvREFCNT_inc()macro.