diag.t: Subdivide exception list #20115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
changed the title
jkeenan
reviewed
Aug 18, 2022
bram-perl
approved these changes
Aug 22, 2022
Some of the entries in this list of diagnostics are ones that people just haven't gotten around to documenting. Patches welcome! But there are, in my opinion, a very few are ones that don't ever need to be documented because the text of the diganostic is sufficiently explanatory in and of itself. This commit revises the comments explaining the exception list, and moves the ones I think are sufficiently self-explanatory to the front.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the entries in this list of diagnostics are ones that people
just haven't gotten around to documenting.
Patches welcome!
But a very few are ones that, in my opinion, don't ever need to be
documented because the text of the diganostic is sufficiently
explanatory in and of itself.
This commit revises the comments explaining the exception list, and
moves the ones I think are sufficiently self-explanatory to the front.
REVIEWERS: See if you agree that these don't need more explanations