pp_hot.c - fix branch reset matches in list context #20741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycoz
reviewed
Jan 26, 2023
tonycoz
reviewed
Jan 26, 2023
tonycoz
reviewed
Jan 26, 2023
tonycoz
reviewed
Jan 26, 2023
demerphq
force-pushed
the
yves/fix_branch_reset_list_context_assignment
branch
from
75fb908
to
8748f64
Compare
demerphq
force-pushed
the
yves/fix_branch_reset_list_context_assignment
branch
2 times, most recently
from
b18fb8a
to
efeaa82
Compare
tonycoz
reviewed
Jan 27, 2023
tonycoz
reviewed
Jan 27, 2023
tonycoz
approved these changes
Jan 27, 2023
I am kinda surprised this issue was not picked up by one of our other test files. I would have expected one of the t/re/regexp.t based patches to validate list context matches populating the list properly. But apparently not! So when I fixed branch reset in fe5492d I missed the list context logic. This fixes the oversight. Thanks to Andreas Koenig for the BBC report on this. This also changes the code to use SSize_t for various length related operations, the original code was using I32 which might break on very very long strings. Thanks to Tony C for pointing that out.
demerphq
force-pushed
the
yves/fix_branch_reset_list_context_assignment
branch
from
efeaa82
to
31aab6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am kinda surprised this issue was not picked up by one of our other test files. I would have expected one of the t/re/regexp.t based patches to validate list context matches populating the list properly. But apparently not! So when I fixed branch reset in fe5492d I missed the list context logic. This fixes the oversight. Thanks to Andreas Koenig for the BBC report on this.