Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-cpan-diff: Make Options Display Consistently in Usage Output #21409

Merged
merged 1 commit into from Sep 6, 2023

Conversation

rwp0
Copy link
Contributor

@rwp0 rwp0 commented Aug 21, 2023

Describe CLI options in usage consistently

add spaces after "local"

@rwp0
Copy link
Contributor Author

rwp0 commented Aug 21, 2023

Not sure what's failing.

@jkeenan
Copy link
Contributor

jkeenan commented Sep 5, 2023

@rwp0, could you rebase this branch on blead and re-push. I think that should clear up the test failures and make this p.r. mergeable. (I fetched your branch and got porting test failures first time around, but when I rebased on blead those failures cleared up.)

Calling perl Porting/core-cpan-diff to get the Usage() statement produced well-aligned results, so once we get CI happy this will be approvable. Thanks.

@jkeenan jkeenan added the Infrastructure Things needed to maintain Perl development label Sep 5, 2023
@jkeenan jkeenan changed the title [doc] core-cpan-diff: Consistent Options in Usage Porting/core-cpan-diff: Consistent Options in Usage Sep 5, 2023
@rwp0 rwp0 changed the title Porting/core-cpan-diff: Consistent Options in Usage core-cpan-diff: Consistent Options in Usage Sep 5, 2023
Describe CLI options in usage consistently

add spaces after "local"
@rwp0
Copy link
Contributor Author

rwp0 commented Sep 6, 2023

@jkeenan done

Did the following on CLI:

git switch blead # making sure I'm in "main"
git pull # update local with remote
git switch blead-3 # branch of this PR

git rebase blead # put this commit on top
git push --force # re-push after rebasing

@rwp0 rwp0 changed the title core-cpan-diff: Consistent Options in Usage core-cpan-diff: Make Options Consistent in Usage Sep 6, 2023
@rwp0 rwp0 changed the title core-cpan-diff: Make Options Consistent in Usage core-cpan-diff: Make Options Display Consistently in Usage Output Sep 6, 2023
@jkeenan jkeenan merged commit 237bb24 into Perl:blead Sep 6, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Things needed to maintain Perl development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants