Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document appearance of "defer" feature in perlsyn.pod #21929

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

dboehmer
Copy link
Contributor

@dboehmer dboehmer commented Feb 5, 2024

Perl version that introduced defer taken from #17949 (comment)

@leonerd
Copy link
Contributor

leonerd commented Feb 5, 2024

Locally, this change appears to be fine. But on a wider perspective, we don't currently document when various syntax features first appeared. If we add it here is raises the question of whether many more of the recent additions should be similarly documented.

I think they probably should, but before we merge this one in particular we should decide on a wider view, if that's the sort of thing we want to do.

@dboehmer
Copy link
Contributor Author

dboehmer commented Feb 5, 2024

I actually tried to find out when defer became available and didn’t find a list. perldoc feature does also only mention that it is experimental.

Both perldoc feature and perldoc -f defer refer to perldoc perlsyn. So I looked there and several syntax features are already described with the Perl version required:

@khwilliamson
Copy link
Contributor

Other commits that add similar information have been approved in recent releases, in spite of such concerns.

I think the de-facto rule is "If this bothered someone enough that they created a PR, then accept it".

I think that is reasonable, so this LGTM

@leonerd
Copy link
Contributor

leonerd commented Feb 6, 2024

Fair enough. In that case we'll merge this one now and we can make a more thorough sweep of perlsyn, etc.. to add similar notes about when other recent additions appeared separately.

@leonerd leonerd merged commit 425d89e into Perl:blead Feb 6, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants