Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove underscore from VERSION in podlators #22180

Merged
merged 1 commit into from
May 4, 2024

Conversation

haarg
Copy link
Contributor

@haarg haarg commented Apr 28, 2024

When using versions with underscores, best practice is to remove the underscore on a later line, to allow using the version as a number when accessing the variable directly.

@jkeenan
Copy link
Contributor

jkeenan commented May 4, 2024

@haarg, could you run:

$ cd t; ./perl -I../lib porting/customized.t --regen; cd -

... to enable t/porting/customized.t to pass? Thanks.

When using versions with underscores, best practice is to remove the
underscore on a later line, to allow using the version as a number when
accessing the variable directly.
@haarg haarg force-pushed the haarg/remove-underscore-podlators branch from b2547d9 to 229ee78 Compare May 4, 2024 18:15
@haarg haarg merged commit 9fd1426 into blead May 4, 2024
59 checks passed
@haarg haarg deleted the haarg/remove-underscore-podlators branch May 4, 2024 20:05
@jkeenan
Copy link
Contributor

jkeenan commented May 4, 2024

Thanks. I note that the podlators distribution is moving to semantic versioning, so we can expect to have to modify its entry in Porting/Maintainers.pl in the future.

@haarg
Copy link
Contributor Author

haarg commented May 4, 2024

The underscores only exist because we needed to patch the module in core. Once blead is open for new development, we should be able to just sync the new stable version and eliminate the customizations.

If in the future we need to customize a module that declares its version using the package statement, it will require extra work because that type of declaration doesn't allow underscores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants