Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

stage install to blib when building PPM files for ActiveState #114

Merged
merged 1 commit into from Apr 17, 2015
Merged

stage install to blib when building PPM files for ActiveState #114

merged 1 commit into from Apr 17, 2015

Conversation

plicease
Copy link
Contributor

This should resolve the issue raised in this comment:

#94 (comment)

Problem is that ActiveState Perl when constructing ppm files uses just the files in blib. They do not, in fact, run ./Build install at all. Happily a PPM build can be detected through an environment variable.

Instead of installing to the final location during the ./Build install we install to the staged share directory during the ./Build step for ActiveState installs ONLY, or if the AB subclass requests it. I plan on using this feature for Alien::FFI even for non AS installs.

In addition, this PR would resolve #94 completely if made the default, which I think we should consider, but is not included in this patch. We can discuss making this a default option on #94 as needed, but I would like to see at least this get merged as soon as possible.

@mohawk2
Copy link
Contributor

mohawk2 commented Apr 16, 2015

If it works, I'm in favour. @jberger ?

@jberger
Copy link
Member

jberger commented Apr 17, 2015

Same. I can't say I like that kind of specialization, but then again, we
already have to deal with blib, what's one more?
On Apr 16, 2015 4:58 PM, "mohawk2" notifications@github.com wrote:

If it works, I'm in favour. @jberger https://github.com/jberger ?


Reply to this email directly or view it on GitHub
#114 (comment)
.

@plicease plicease merged commit 07fe7e9 into Perl5-Alien:master Apr 17, 2015
@plicease
Copy link
Contributor Author

Merged, and sending to CPAN as 0.015_01. I will do some more testing with this, and will send it as a production version Monday or Tuesday if it is looking good on cpan testers.

@jberger
Copy link
Member

jberger commented Apr 17, 2015

@plicease ++

plicease added a commit that referenced this pull request Apr 20, 2015
@plicease plicease deleted the install-to-blib branch April 22, 2015 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alien::Base Runtime accessing installation directory
3 participants