-
Notifications
You must be signed in to change notification settings - Fork 148
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix multiple savepointing transactions on DBD::SQLite
Problem was missed during review of 86a5147 (how the fuck did I let this abomination through anyway), and not encountered due to insufficient testing. The naive statement parser in DBD::SQLite when running against older libsqlite mistakenly treats ROLLBACK TRANSACTION TO... as an actual TXN rollback, and as a result desyncs the internal AutoCommit flag state [1] Fix by simply using the shorter (still valid) syntax [2], and by removing the sloppy workaround hiding the actual problem. [1] https://github.com/DBD-SQLite/DBD-SQLite/blob/1.42/dbdimp.c#L824:L852 [2] http://www.sqlite.org/lang_savepoint.html
- Loading branch information
Showing
4 changed files
with
60 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters