Weaken $self to avoid leaks with nested closures on 5.8

Perl5 · Oct 21, 2014 · cf52a9a · cf52a9a
1 parent 1d29e7e
commit cf52a9a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/DBIx/Class/Storage/DBI/Informix.pm b/lib/DBIx/Class/Storage/DBI/Informix.pm
@@ -6,6 +6,7 @@ use base qw/DBIx::Class::Storage::DBI/;
 use mro 'c3';
 
 use Scope::Guard ();
+use Scalar::Util 'weaken';
 use Context::Preserve 'preserve_context';
 use namespace::clean;
 
@@ -66,6 +67,7 @@ sub with_deferred_fk_checks {
 
   $self->_do_query('SET CONSTRAINTS ALL DEFERRED');
 
+  weaken($self);
   return preserve_context {
     my $sg = Scope::Guard->new(sub {
       $self->_do_query('SET CONSTRAINTS ALL IMMEDIATE');

diff --git a/lib/DBIx/Class/Storage/DBI/Pg.pm b/lib/DBIx/Class/Storage/DBI/Pg.pm
@@ -6,6 +6,7 @@ use warnings;
 use base qw/DBIx::Class::Storage::DBI/;
 
 use Scope::Guard ();
+use Scalar::Util 'weaken';
 use Context::Preserve 'preserve_context';
 use DBIx::Class::Carp;
 use Try::Tiny;
@@ -30,6 +31,7 @@ sub with_deferred_fk_checks {
 
   $self->_do_query('SET CONSTRAINTS ALL DEFERRED');
 
+  weaken($self);
   return preserve_context {
     my $sg = Scope::Guard->new(sub {
       $self->_do_query('SET CONSTRAINTS ALL IMMEDIATE');