Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_subselect_rs new resultset bugfix #105

Closed
wants to merge 1 commit into from
Closed

Conversation

x86-64
Copy link
Contributor

@x86-64 x86-64 commented May 29, 2016

When using ->pager->count on complicated resultset this error pops up:
Single parameters to new() must be a HASH ref at /usr/lib64/perl5/site_perl/5.12.3/x86_64-linux/Moose/Object.pm line 30 Moose::Object::BUILDARGS('PODirect::Schema::ResultSet::user', 'DBIx::Class::ResultSource::Table=HASH(0x9d5e0f0)') called at /usr/lib64/perl5/site_perl/5.12.3/MooseX/NonMoose/Meta/Role/Class.pm line 154 MySchema::Schema::ResultSet::user::new('PODirect::Schema::ResultSet::user', 'DBIx::Class::ResultSource::Table=HASH(0x9d5e0f0)') called at /usr/lib64/perl5/site_perl/5.12.3/DBIx/Class/ResultSet.pm line 3389 DBIx::Class::ResultSet::as_subselect_rs('PODirect::Schema::ResultSet::user=HASH(0x7f32b0acac30)') called at /usr/lib64/perl5/site_perl/5.12.3/DBIx/Class/ResultSet.pm line 1766 DBIx::Class::ResultSet::_count_subq_rs('PODirect::Schema::ResultSet::user=HASH(0x7f32b0abf518)', 'HASH(0x7f32b0acc820)') called at /usr/lib64/perl5/site_perl/5.12.3/DBIx/Class/ResultSet.pm line 1604 DBIx::Class::ResultSet::count('PODirect::Schema::ResultSet::user=HASH(0x7f32b0abf518)') called at /usr/lib64/perl5/site_perl/5.12.3/DBIx/Class/ResultSet.pm line 2536 DBIx::Class::ResultSet::__ANON__ at /usr/lib64/perl5/site_perl/5.12.3/DBIx/Class/ResultSet/Pager.pm line 15 DBIx::Class::ResultSet::Pager::_total_entries_accessor('DBIx::Class::ResultSet::Pager=HASH(0x7f32b0acc178)') called at /usr/lib64/perl5/vendor_perl/5.12.3/Data/Page.pm line 50 Data::Page::total_entries('DBIx::Class::ResultSet::Pager=HASH(0x7f32b0acc178)') called at test.pl line 85

Sample code:
my $s = $ex->search_rs({ "category.category" => 'test' }, { 'page' => 1, 'rows' => 10, 'prefetch' => [ { 'table1' => [ { 'table2' => [] } ] } ], });

This small fix resolves the problem.

@ribasushi
Copy link
Collaborator

Thank you! Your work has been merged with extended testing/docs as 1513a73. Release should happen some time this year. Sorry for the massive delay :/

@ribasushi ribasushi closed this Nov 6, 2019
@x86-64
Copy link
Contributor Author

x86-64 commented Nov 8, 2019

Thank you, just recently stumbled on this bug again and had to manually patch. Better late than never :)

@ribasushi
Copy link
Collaborator

This finally shipped as 0.082842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants