Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in resolve_relationship_condition with sources with virtual columns #115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix bug in resolve_relationship_condition with sources with virtual columns #115

wants to merge 3 commits into from

Commits on Oct 16, 2017

  1. Fix changelog - text no longer applies after 7648acb

    @vanstyn
    vanstyn committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    e5385b6 View commit details
    Browse the repository at this point in the history

  2. Bit forgotten in 5f48fa5 generates a ton of spurios .pod's

    @vanstyn
    vanstyn committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    1044aa1 View commit details
    Browse the repository at this point in the history

  3. Fix fallout from 786c1cd 

    Before the interface of resolve_relationship_condition was simplified, it
contained a codepath exempting result objects from any checks of their
get_columns() results.

Keep the stringent check ( so that new code using this function will not
assume questionable defaults going forward ), and instead fix all callsites
where this condition might arise

--

This commit fixes the bug revealed by downstream RapidApp test case in
this commit:

 * vanstyn/RapidApp@c319a41904

Huge thanks to @ribasushi for identifing the needed code changes to
address this once I was able to provide the failing test case in
RapidApp
    @vanstyn
    vanstyn committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    942c5be View commit details
    Browse the repository at this point in the history