Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid critic exception by doing it right #280

Merged
merged 1 commit into from Jul 21, 2021
Merged

Conversation

plicease
Copy link
Member

No description provided.

@Grinnz
Copy link

Grinnz commented Jul 21, 2021

Can be inlined like: (my $x = $_) =~ s/(\s)/\\$1/g;

@plicease
Copy link
Member Author

Can be inlined like: (my $x = $_) =~ s/(\s)/\\$1/g;

True! I guess I find the three line version more readable, but your version is a common idiom.

@plicease plicease merged commit be5ae0c into main Jul 21, 2021
@plicease plicease deleted the graham/wrapper-critic branch July 21, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants