Allow 'before_error_render' hook to modify token values passed to the rendering engine. #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second one is a hashref holding the tokens that will be passed to the template rendering engine. This gives that hook an opportunity to modify the token values, and even more importantly to add any extra tokens necessary for the proper rendering of the error template. This change gives 'before_error_render' the same functionality that is already provided to 'before_template_render', putting it on an equal footing.
|
I had to patch my local version of Dancer to do this, which sticks in my craw. Can you please merge this? I cannot think of any good reason why before_error_render should not have access to the same information that before_template_render already does. |
bigpresh
approved these changes
Jun 29, 2022
|
Hilariously belatedly, but thanks! |
|
I’m glad to see this finally incorporated into a release version! I look forward to being able to delete my local patch.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'before_error_render' hook is now called with two arguments. The
second argument is a hashref holding the tokens that will be passed to the
template rendering engine. This gives that hook an opportunity to modify
the token values, and even more importantly to add any extra tokens
necessary for the proper rendering of the error template.
This change gives 'before_error_render' the same functionality that is
already provided to 'before_template_render', putting it on an equal
footing.