Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please disable tests with Test::TCP on Win32 #492

Closed
wchristian opened this issue Apr 28, 2011 · 2 comments
Closed

please disable tests with Test::TCP on Win32 #492

wchristian opened this issue Apr 28, 2011 · 2 comments

Comments

@wchristian
Copy link
Contributor

Some of Dancer's tests use Test::TCP when available. However on Win32 Test::TCP is highly unreliable and whether it actually works for any given run is entirely random.

As such Dancer generates bogus test results when trying to install on Win32 with Test::TCP present.

@ghost ghost assigned fcuny Apr 28, 2011
@fcuny
Copy link
Contributor

fcuny commented Apr 28, 2011

I've started to rewrite the tests in a branch, and I've already removed most of the tests using Test::TCP when it's possible.

will try to finish this one ASAP

@xsawyerx
Copy link
Member

Agreed, makes perfect sense. Also, the cat in the avatar makes a good point.

@wchristian, thanks for reporting.

@fcuny fcuny closed this as completed in 0d70c98 Jun 1, 2011
@fcuny fcuny removed their assignment May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants