Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented missing placeholders in log_format; some additional fixes. #760

Closed
wants to merge 1 commit into from
Closed

implemented missing placeholders in log_format; some additional fixes. #760

wants to merge 1 commit into from

Conversation

lhengstmengel
Copy link
Contributor

No description provided.

@xsawyerx
Copy link
Member

Comments from the mailing list:

setting('charset') triggered an error (undefined function). I changed it to $self->config->{'charset'} however $self->config appears to be an empty hashref. I expected it to contain the app config (with at least a key charset as that is in the config.yml). Is this assumption correct? If not, what is the best way to get access to the app config / charset setting?

@xsawyerx xsawyerx added this to the 0.155000 milestone Nov 23, 2014
@xsawyerx xsawyerx mentioned this pull request Nov 23, 2014
Closed
@xsawyerx
Copy link
Member

Merged, thanks! 👍

@xsawyerx xsawyerx closed this Nov 27, 2014
xsawyerx added a commit that referenced this pull request Nov 28, 2014
@xsawyerx
v0.155000
b810420 
    [ BUG FIXES ]
    * GH #773, #775: AutoPage handler no longer renders layouts.
      (Dávid Kovács, Sawyer X)
    * GH #770: Prevent crazy race condition between the logger engine and
      other engines. This means engines now call "log_cb" to log.
      (Sawyer X)
    * App now has default name to caller package. (Sawyer X)
    * Serializers will not try to serialize empty content. (Sawyer X)
    * Lots of cleanups in Core::Request in favor of Plack::Request.
      (Sawyer X)

    [ ENHANCEMENTS ]
    * Layouts directory can be configured using 'layout_dir'.
      (Sawyer X)
    * GH #648, #760: Logger format now supports 'h', 'u', 'U', 'h', 'i'.
      They are documented but weren't really available.
      (Lennart Hengstmengel)
    * Serializers having errors will not fail if there is no logger.
      (Sawyer X)
    * Create a request object with a single argument of $env, like
      Plack::Request. (Sawyer X)

    [ DOCUMENTATION ]
    * Remove documented hack for static content because we use the middleware
      now anyway. (Sawyer X)
    * Document further the difference between splat and megasplat.
      (Dávid Kovács)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.155000
Development

Successfully merging this pull request may close these issues.
2 participants
@lhengstmengel @xsawyerx