Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation and App's default config mismatch #777

Closed
DavsX opened this issue Nov 25, 2014 · 1 comment
Closed

Documentation and App's default config mismatch #777

DavsX opened this issue Nov 25, 2014 · 1 comment
Labels
Beginner Suitable Documentation
Milestone
0.156000

Comments

@DavsX
Copy link

DavsX commented Nov 25, 2014

Hi!
Hope I get it correctly:
In the docs there is a mention about a config named 'public', whereas
in (D2::C::App->_build_default_config)[https://github.com/PerlDancer/Dancer2/blob/master/lib/Dancer2/Core/App.pm#L524] there is 'public_dir'. I assume they mean the same thing, in which case we should choose one over the other.
@xsawyerx xsawyerx added this to the 0.156000 milestone Nov 29, 2014
xsawyerx added a commit that referenced this issue Dec 6, 2014
@xsawyerx
fixed per #777
9bd1626
@xsawyerx
Copy link
Member

xsawyerx commented Dec 6, 2014

Fixed. Thanks. :)

@xsawyerx xsawyerx closed this as completed Dec 6, 2014
xsawyerx added a commit that referenced this issue Dec 7, 2014
@xsawyerx
v0.156000
ab30cf0 
    [ BUG FIXES ]
    * Do not try to deserialize empty content.
      (Lennart Hengstmengel, Sawyer X)
    * Do not call serialization hooks when no serialization took place.
      (Sawyer X)
    * Be more cautious on undef output from serializer.
      (Daniel Böhmer, Sawyer X)

    [ ENHANCEMENTS ]
    * Add cpanfile when scaffolding a new app.
      (Dávid Kovács, Sawyer X)
    * Response "content" attribute no longer stringifies. This should help
      reduce warnings, odd debugging problems, etc. (Sawyer X)
    * DSL "uri_for" no longer returns URI object. Instead just the URI.
      (Sawyer X)

    [ DOCUMENTATION ]
    * GH #777: Fix doc for mentioning public dir.
      (Dávid Kovács, Sawyer X)
    * GH #787: Document all environment variables. (Sawyer X)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Suitable Documentation
Projects
None yet
Milestone
0.156000
Development

No branches or pull requests
2 participants
@xsawyerx @DavsX