Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnings flag? #802

Closed
xsawyerx opened this issue Dec 6, 2014 · 3 comments
Closed

warnings flag? #802

xsawyerx opened this issue Dec 6, 2014 · 3 comments
Labels
Beginner Suitable Question
Milestone
0.157000

Comments

@xsawyerx
Copy link
Member

xsawyerx commented Dec 6, 2014

Is the warnings flag even used?
(This is related to DANCER_WARNINGS environment variable.)
@xsawyerx xsawyerx added this to the 0.157000 milestone Dec 6, 2014
@IISResetMe
Copy link

No, it's only being referenced in t\classes\Dancer2-Core-Runner\new.t, same goes for $ENV{DANCER_WARNINGS}

@xsawyerx
Copy link
Member Author

@IISResetMe Thanks!

I'll just remove it and add it to the migration document.

xsawyerx added a commit that referenced this issue Dec 11, 2014
@xsawyerx
GH #802: Remove warnings and DANCER_WARNINGS:
0bc2da1 
This option existed in Dancer 1 as a whim. We no longer support it
and we now document how you should achieve what people wanted
originally.
@xsawyerx
Copy link
Member Author

Done.

xsawyerx added a commit that referenced this issue Dec 14, 2014
@xsawyerx
v0.157000
d34af88 
    [ BUG FIXES ]
    * GH #799: Set current request earlier so log formats using requests
      will work. (Sawyer X)
    * GH #650: Provide default environment to app for templating.
      (Dávid Kovács, Chi Trinh)
    * GH #800: Better portability code, for different Windows situations.
      (Christian Walde)
    * Less littering of the test directories with session files. (Sawyer X)

    [ ENHANCEMENT ]
    * GH #810: strict && warnings in the app.pl. (Sawyer X)
    * Use to_app keyword in skeleton. (Sawyer X)
    * GH #801: Under production, server tokens are disabled. (Sawyer X)
    * GH #588, #779: Remove LWP::UserAgent in favor of HTTP::Tiny.
      (Dávid Kovács, simbabque, Sawyer X)
    * Remove all usages of Test::TCP in favor of Plack::Test. (Sawyer X)

    [ DOCUMENTATION ]
    * GH #802: Remove indication of warnings configuration option
      and add explanation in migration document. (Sawyer X)
    * GH #806: Link in main docs to the migration document. (Gabor Szabo)
    * GH #807: Update migration document with more session data,
      changes to app.pl, and Template::Toolkit configuration. (Gabor Szabo)
    * GH #813: Update migration document with information on encoding and
      usage of Plack::Request internally. (Gabor Szabo, Sawyer X)
bor added a commit to bor/Dancer2 that referenced this issue Aug 7, 2020
@bor
remove all leftovers after removing 'warnings' config settings
1d0def6 
which was happened in GH PerlDancer#802 (0bc2da1)
bor added a commit to bor/Dancer2 that referenced this issue Aug 7, 2020
@bor
remove all leftovers after removing 'warnings' config setting
802d563 
which was happened in GH PerlDancer#802 (0bc2da1)
@bor bor mentioned this issue Aug 7, 2020
Closed
bor added a commit to bor/Dancer2 that referenced this issue Aug 7, 2020
@bor
remove all leftovers after removing 'warnings' config setting
e13d070 
which was happened in GH PerlDancer#802 (0bc2da1)
cromedome pushed a commit that referenced this issue Jan 19, 2021
@bor @cromedome
remove all leftovers after removing 'warnings' config setting
100ddd9 
which was happened in GH #802 (0bc2da1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Suitable Question
Projects
None yet
Milestone
0.157000
Development

No branches or pull requests
2 participants
@xsawyerx @IISResetMe