New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Dockerfile from the right spot #1623
Conversation
I tested this on a different machine than I developed on prior to release, and had some cruft that masked a bug when adding a Dockerfile to a new application. The dockerfile is located off of the dist dir, not off of the skel dir. This minor fix changes that. I consider this a blocker for the release. Please review ASAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane - but does beg the question of whether the Dockerfile actually ought to be under the skel/
directory? (If for no other reason, being in the skel directory would let the user point at their own skel directory containing a customised Dockerfile that does their own particular needful, no?)
I don't disagree. I put the Dockerfile in a separate directory because I didn't want to include it automatically when everything from We could always take the opposite approach and put it in |
Ah yes, everything from |
That's why I didn't do it that way :) |
It is really small, maybe we can inline it in the CLI module? |
[ BUG FIXES ] * GH #1611: Redirect '/' doesn't always work as expected (Russell @veryrusty Jenkins, Christopher Gurnee) * PR #1620: Quiet spammy failing CI builds (Jason A. Crome) * PR #1623: Copy Dockerfile from the right spot (Jason A. Crome) [ ENHANCEMENTS ] * PR #1613: Add git features to Dancer2 CLI (Jason A. Crome) * PR #1614: Generate Dockerfile when creating new app (Jason A. Crome) [ DOCUMENTATION ] * PR #1563: Fix typos in perlcritic.rc notes (Achyut Kumar Panda) * PR #1609: Document and test for missing DSL keywords (racke, Jason A. Crome) * PR #1618: Provide a consistent list of community resources (Jason A. Crome) * PR #1619: Clarify Dancer2::Template::Simple's role in life (Jason A. Crome)
I tested this on a different machine than I developed on prior to release, and had some cruft that masked a bug when adding a Dockerfile to a new application. The dockerfile is located off of the dist dir, not off of the skel dir. This minor fix changes that.
I consider this a blocker for the release. Please review ASAP.