Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OPTIONS and PATCH requests in the standalone server. #535

Merged
merged 1 commit into from Mar 27, 2014

Conversation

veryrusty
Copy link
Member

Overrides the valid_http_method() method inherited from HTTP::Server::Simple
to allow all request types that the DSL supports in the standalone server. Closes #523.

Overrides the valid_http_method() method inherited from HTTP::Server::Simple
to allow all request types that the DSL supports.
@racke
Copy link
Member

racke commented Mar 26, 2014

This makes a lot of sense and should be applied to Dancer 1 as well. Do we need a specific version o f HTTP::Server::Simple::PSGI for that?

Regards
Racke

@xsawyerx
Copy link
Member

👍 !

@racke
Copy link
Member

racke commented Mar 27, 2014

valid_http_method was introduced into HTTP::Server::Simple ages ago (2006), so IMHO we are fine without an dependency on that.

racke added a commit that referenced this pull request Mar 27, 2014
…patch

Allow OPTIONS and PATCH requests in the standalone server.
@racke racke merged commit 763a1bd into master Mar 27, 2014
@racke
Copy link
Member

racke commented Mar 27, 2014

Thanks a lot, veryrusty!

@veryrusty veryrusty deleted the pr/server_standalone_options_patch branch August 15, 2014 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.pl does not support OPTIONS verb
3 participants