Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test skeleton to use to_app #742

Closed
wants to merge 2 commits into from
Closed

Update test skeleton to use to_app #742

wants to merge 2 commits into from

Conversation

DavsX
Copy link

@DavsX DavsX commented Oct 31, 2014

Change Dancer2->psgi_app to the new-style MyApp->to_app

@DavsX DavsX mentioned this pull request Oct 31, 2014
Closed
@xsawyerx
Copy link
Member

Any chance to add another commit that changes to the OO version of Plack::Test?

@xsawyerx
Copy link
Member

And of course, 👍 :)

@racke
Copy link
Member

racke commented Oct 31, 2014

How do you apply the "OO version" ? Examples?

@DavsX
Copy link
Author

DavsX commented Oct 31, 2014

Sure, I'll look into it.

@racke for examples see this PR, or for example t/dsl/content.t

@DavsX
Copy link
Author

DavsX commented Oct 31, 2014

Is the OO way of Test::Plack the preferred way now? Because based on a quick grep there are many tests which use test_psgi in the 'procedural' form. Would updating them to the OO way be a good/desired thing?

@xsawyerx
Copy link
Member

I'd prefer the OO way now. It didn't exist originally and was added later.

@xsawyerx xsawyerx added this to the 0.154000 milestone Nov 9, 2014
@xsawyerx
Copy link
Member

Merged, thanks! 👍

@xsawyerx xsawyerx closed this Nov 17, 2014
xsawyerx added a commit that referenced this pull request Nov 17, 2014
@xsawyerx
v0.154000
775ff73 
    [ BUG FIXES ]
    * GH #744: Serialize anything, not just references. (Sawyer X)
    * GH #744: Serialize regardless of content_type of serializer. (Sawyer X)
    * GH #764: Catch template render errors. (Russell Jenkins, Steven Humphrey)
    * Calling uri_for(undef) doesn't crash. (Sawyer X)
    * GH #732: Correct name for 403 (Forbidden, not Unauthorized).
      (Theo van Hoesel, Sawyer X, Mickey Nasriachi, Omar M. Othman)
    * GH #753: Syntax of parameterized types. (Russell Jenkins)
    * GH #734: Failing tests on Windows. (Russell Jenkins, Sawyer X)

    [ ENHANCEMENTS ]
    * GH #664, #684, #715: Handler::File replaced for static files with
      Plack::Middleware::Static, allowing files to be served *before* routes.
      This means hooks do not apply to static files anymore!
      (Russell Jenkins, DavsX)
    * Engines now have "logger" attribute to log errors. It sends the
      Dancer2::Logger:: object, if one exists. (Sawyer X)
    * Serializers do not need to implement "loaded" method. (Sawyer X)
    * GH #733: In core: response_xxx removed in favor of generic
      standard_response. (Sawyer X, Mickey Nasriachi, Omar M. Othman)
    * GH #514, #642, #729: Allow mixing named params, splat, and
      megasplat. (Russell Jenkins, Johan Spade, Dávid Kovács)
    * GH #596: no_server_tokens works, as well as DANCER_NO_SERVER_TOKENS.
      (Omar M. Othman, Sawyer X, Mickey Nasriachi)
    * GH #639: Validate engine types in configuration.
      (Sawyer X, Omar M. Othman, Mickey Nasriachi, Russell Jenkins)
    * GH #663, #741: Remove "accept_type" attribute and other references.
      (Mickey Nasriachi, Theo van Hoesel)
    * GH #748: Provide forwarded_host, forwarded_protocol. (Sawyer X)
    * GH #748: Do not provide a default env, require env for a request.
      (Sawyer X)
    * GH #742: Update test skeleton to use to_app. (Dávid Kovács)
    * GH #636: Use Plack::Test in more tests. (Dávid Kovács)

    [ DOCUMENTATION ]
    * GH #656: Dancer2::Manual::Testing as a guide for testing Dancer2
      applications. (Sawyer X)
    * Improved documentation of route matching. (Russell Jenkins)
    * Migration document update relating to enhancements.
      (Sawyer X, Mickey Nasriachi)
    * GH #731: Document changes in session.
      (racke, Sawyer X, Mickey Nasriachi, Omar M. Othman)
    * Document "id" attribute in Request object. (Sawyer X)
    * Correct Cookbook examples on command line scripts. (Sawyer X)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.154000
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DavsX @xsawyerx @racke @kovdavid