fix docs #967
fix docs #967
Conversation
|
Can I merge this one? It is docs, so, no big deal, but would like a 👍 |
|
I did wonder if the param However, I don't want to discourage correct docs, so merge away if you don't think its confusing. |
|
But aren't all form fields parameters? But I can add some text to make it clear, if you like ;) |
|
There are two params named |
|
And you say you are rusty :-P sorry, and thanks for pointing me to the route line, I didn't look to it with caution. probably I can change the upload route and remove the parameter, that is "useless" for the example. Anything against it? |
|
@ambs Feel free to totally rework the example :) |
|
@veryrusty, minor change. In vacations, so, trying to work the less possible O:-) |
|
@ambs that still not right; |
|
Gah, stupid me. -----Original Message----- @ambs that still not right; Reply to this email directly or view it on GitHub: |
[ BUG FIXES ]
* GH #947, #948: Escape file paths in regex patterns. (A. Sinan Unur)
* GH #944: Setting response content in before hook when a serializer
is set no longer triggers an error.
(Russell Jenkins, Dmitrii Tcyganov)
* GH #965: Remove non-existant role from Response::Delayed.
(Vernon, Russell Jenkins)
* GH #971: Route options matching no longer uses each iterator.
(Tina Müller)
* GH #959: Custom error template rendering fixed. (Russell Jenkins)
* GH #961: Render custom error templates in before hooks. (Russell Jenkins)
* GH #978: Tests - fix response regex after html_encode (Vernon)
* GH #972: Exceptions thrown by serializers no longer masked.
(Russell Jenkins)
[ DOCUMENTATION ]
* GH #967: Fix upload example. (Alberto Simões)
* GH #881: Add cookie timeout example. (Andy Beverley)
* GH #963: Document all available template tokens. (Sawyer X)
[ ENHANCEMENTS ]
* Optimize the s*#t out of basic routing. Faster than Dancer 1 now.
(Sawyer X)
* Only load HTTP::Server::PSGI when asked to start a development
server not under Plack. (Sawyer X, Mickey Nasriachi)
* GH #949: Produce cleaner, non-verbose test output (Vernon)
* GH #950: Decode characters in param keys (Patrick Zimmermann)
* GH #914: Include stack trace on default error page when
show_errors is true. (Vernon)
* GH #980, #981: halt keyword sets response content if provided,
as Dancer 1 does. (Achilles Kars)
* GH #909, #957, #983: HTML5 templates in generated apps and
default error template (Gabor Szabo, Kadir, Vernon)
* GH #972, #719, #969, #644, #647: Streamline serializer helpers.
to_json/from_json now faster. (Russell Jenkins)
the previous documentation used '$filename' as argument to upload, but it should be the field name.