Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for dancer2 1.0.0 #1

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Prep for dancer2 1.0.0 #1

merged 3 commits into from
Dec 13, 2023

Conversation

cromedome
Copy link
Contributor

Replace Dancer2::Test, and fix some packaging problems so we can create an updated version that will install with Dancer2 1.0.0.

Dancer2::Test was soft-deprecated in v0.400000, and in the upcoming
1.0.0 release, it will be hard deprecated, and these tests would stop
working. Test suite should now pass regardless of Dancer2 version.
This was transferred from xdg to the core team, and the readme didn't
reflect the change.

This isn't properly updated in the build process, so I had to build it,
copy it from the packaged module, and update it here.
The version of xdg's Dist::Zilla at the time of writing this didn't
include pod coverage and version tests that fail when run against this
repo. Removed the newer tests, and everything is happy again.
@@ -2,10 +2,13 @@ name = Dancer2-Plugin-Syntax-GetPost
author = David Golden <dagolden@cpan.org>
license = Apache_2_0
copyright_holder = David Golden
copyright_year = 2012
copyright_year = 2023
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite the bump!

Copy link

@yanick yanick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy. Ship it!

@cromedome cromedome merged commit 59ae8fb into master Dec 13, 2023
@cromedome cromedome deleted the prep-for-dancer2-1.0.0 branch December 13, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants