Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

E_NOTICE when not using options #2

Closed
ruanpetterson opened this issue Oct 6, 2016 · 2 comments
Closed

E_NOTICE when not using options #2

ruanpetterson opened this issue Oct 6, 2016 · 2 comments

Comments

@ruanpetterson
Copy link

ruanpetterson commented Oct 6, 2016

Description

When we use a basic import (i.e. [TableImporter>test.json]), we get E_NOTICE errors of undefined index and undefined constant options.

Suggestion

Change grav-plugin-table-importer/table-importer.php:85 to $options = isset($match[3]) ? $match[3] : []; and grav-plugin-table-importer/table-importer.php:86 to if (!empty($options)) {.

Versions

$ php --version
PHP 7.0.8-0ubuntu0.16.04.2 (cli) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.8-0ubuntu0.16.04.2, Copyright (c) 1999-2016, by Zend Technologies

$ bin/gpm --version
Grav Package Manager version 1.1.5

$bin/gpm info table-importer

GPM Releases Configuration: Stable

Found package 'table-importer' under the 'Plugins' section

Table Importer [table-importer]
-------------------------------
Imports tables from JSON, YAML, and CSV formats into Markdown tables within a page

Author      : Aaron Dalton <aaron@daltons.ca> 
Version     : 1.0.1
Keywords    : grav, plugin, tables, import, json, yaml, csv
Last Update : Tue, 16 Sep 2014, 00:07:16, +00:00 
Homepage    : https://github.com/Perlkonig/grav-plugin-table-importer
Demo        : https://perlkonig.com/demos/table-importer
Docs        : https://github.com/Perlkonig/grav-plugin-table-importer/blob/master/README.md
Repository  : https://github.com/Perlkonig/grav-plugin-table-importer
Bugs        : https://github.com/Perlkonig/grav-plugin-table-importer/issues
Download    : https://github.com/Perlkonig/grav-plugin-table-importer/zipball/v1.0.1
License     : MIT
@Perlkonig
Copy link
Owner

Doh! How did I not test for that? Thanks. I'll make that change.

@Perlkonig
Copy link
Owner

New release pushed. Sorry! Thanks for the report!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants