Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Taxonomy tag url wrong #2

Closed
ghost opened this issue Aug 17, 2018 · 3 comments
Closed

Taxonomy tag url wrong #2

ghost opened this issue Aug 17, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 17, 2018

The generated URLs are wrong.

The following doesn't help:
{% include 'partials/tagcloud.html.twig' with {'base_url':new_base_url, 'taxonomy':'tag'} %}

So I kind of fixed it for now but this might have to be fixed permanently for others too.

Output:
href="{{ base_url }}/tag{{ tax|e('url') }}

<span class="{{ class }}" title="{{ value }} posts"><a href="{{ base_url }}/tag{{ config.system.param_sep }}{{ tax|e('url') }}">{{ tax }}</a></span>

Expected Output:
href="{{ base_url }}/taxonomy?name=tag&val={{ tax|e('url') }}

Thanks!

@Perlkonig
Copy link
Owner

I think this is more a problem with my Knowledge Base theme than the plugin. The plugin syntax should work in most setups, and it really should work for the KB theme, too. I'll have to figure out why it's not. Thanks!

@Perlkonig
Copy link
Owner

Oh I remember now. Well, that's why it's so easy to override and customize 😄 This isn't something I can trivially make work everywhere. The current state is the one that will work on the most installs.

If I add this to the KB skeleton, then I'll include the template override so the user doesn't have to think about it.

@ghost
Copy link
Author

ghost commented Aug 20, 2018

Can you please make this optional in the plugin settings? So it would then support both ways but work instantly for users.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant