Ensure sftp calls always resolve #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want our service to always return a response (even if the response is a failure status). Otherwise, clients will hang while waiting for a server response. Issue #121 All sftp events must resolve!
Fenn-CS
approved these changes
Apr 17, 2023
|
@Fenn-CS ty! Also no worries at all, this stuff was added a long long long time ago (maybe even a year ago) and we didn't quite know the ramifications of not sending a response at that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few SFTP handlers that were not providing a response to the SFTP client, which could result in client hangs in some circumstances.
Resolves #121