Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recurrences #26

Merged
merged 22 commits into from Aug 28, 2019
Merged

Recurrences #26

merged 22 commits into from Aug 28, 2019

Conversation

Unnar
Copy link
Member

@Unnar Unnar commented Jun 14, 2019

Proof trees can now use the recurrence relation implied by themselves to count how many objects there are of each length as long as it only uses

  • Disjoint union
  • Decomposition
  • Verification (and get_genf is implemented for verified nodes)
  • Recursion

Unnar and others added 14 commits April 11, 2019 16:29
@Unnar
Combinatorial_class: Added new methods, changed some methods from abs…
8d1a384 
…tract to standard implementations
@Unnar
Resolved merge conflict
c4b432f
@Unnar
ProofTree nodes can now calculate objects of length using the recurre…
6ee8f7c 
…nce implied by the ProofTree
@Unnar
Fixed infinite recursions
ac5db98
@Unnar
Recurrence relation now assumes all previous terms are 0 if they were…
25b39d3 
… not computed earlier. Added parameter to ensure_terms for expanding extra terms each time and added docstrings.
@Unnar
Changed ensure_terms to expand 100 terms each time by default. Added …
fa3c962 
…base cases to compositions
@Unnar
Merge branch 'develop' of github.com:PermutaTriangle/comb_spec_search…
2b45203 
…er into recurrences
@Unnar
Updated CHANGELOG
258d77d
@Unnar
Added message to NotImplementedErrors of is_epsilon, is_atom and is_p…
934e52a 
…ositive
@Unnar
Fixed pep8 and isort errors
a277bb5
@enadeau
Remove from_string method
226bae4
@Unnar
Re-added NotImplementedError that was removed by automatic merge
74ba049
@Unnar
Merge branch 'recurrences' of github.com:PermutaTriangle/comb_spec_se…
a6d2d27 
…archer into recurrences
@christianbean
Merge branch 'develop' into recurrences
baf7eda
christianbean
christianbean approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@christianbean christianbean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to be added to develop.

enadeau
enadeau reviewed Aug 27, 2019
View reviewed changes
Copy link
Member

@enadeau enadeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add an example of this functionality that will also serve as test to the README file

CHANGELOG.md Outdated Show resolved Hide resolved
@ulfarsson ulfarsson merged commit 8cde665 into develop Aug 28, 2019
@ulfarsson ulfarsson deleted the recurrences branch August 28, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enadeau enadeau enadeau left review comments

@christianbean christianbean Awaiting requested review from christianbean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Unnar @christianbean @enadeau @ulfarsson