Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An invalid phone number can't be detected. #5

Open
Persdre opened this issue Nov 13, 2020 · 1 comment
Open

An invalid phone number can't be detected. #5

Persdre opened this issue Nov 13, 2020 · 1 comment

Comments

@Persdre
Copy link
Owner

Persdre commented Nov 13, 2020

In this example, the phone number is 9432 which is unrealistic as it is too short. But it is not detected.

Screenshot 2020-11-13 at 5 08 11 PM

@nus-se-bot
Copy link

nus-se-bot commented Nov 18, 2020

Team's Response

TAsker is meant to be able to be used by foreign students (in their own countries) in the future. In countries like Sweden, 7 digit phone numbers are used (excluding extension) and there are countries like Canada with phone extension of +1. Countries like Niue have only 4 digit phone numbers (excluding extension) too.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: You didn't mention it is used for foreign students in the user guide and developer guide :). Based on your explanations, you should have mentioned it but you didn't.


❓ Issue type

Team chose [type.DocumentationBug]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: [replace this with your reason]


❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: The definition of very low is "a typo/spacing/layout/color/font issues in the docs or the UI that doesn't affect usage." But it will influence users' usage when they mistakenly type in an unrealistic number. And it is not layout/typo/color issue.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants