Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlg0551.tlg004-tlg0551.tlg006 #1267

Merged
merged 4 commits into from
May 10, 2021
Merged

tlg0551.tlg004-tlg0551.tlg006 #1267

merged 4 commits into from
May 10, 2021

Conversation

AlisonBabeu
Copy link
Collaborator

Checking in some of latest fixes to Appian Perseus headers.

@AlisonBabeu AlisonBabeu requested a review from lcerrato May 10, 2021 14:23
@ghost
Copy link

ghost commented May 10, 2021

Hook UI build recap

lower case Greek
fixing Greek title
correcting Greek title
@lcerrato
Copy link
Collaborator

@AlisonBabeu
Just a reminder that the edition label should equal the edition file title.
So if you adopt the Greek in the label that should carry over to the file title, too.

These Appian files may not be the best for the Greek as this is all upper case, and I use the normalized cases. I noticed a few transcription errors in this batch. It's hard because there aren't good normalized examples for these so the accentuation can be tricky.

If possible, we try to get the target link to the work page start, too.

@ghost
Copy link

ghost commented May 10, 2021

Hook UI build recap

@ghost
Copy link

ghost commented May 10, 2021

Hook UI build recap

@ghost
Copy link

ghost commented May 10, 2021

Hook UI build recap

@AlisonBabeu
Copy link
Collaborator Author

Hey @lcerrato thanks for reviewing. I will ditch the Greek titles for now I was copying them from some OCR and if it has issues the last thing I want to do is introduce more errors. I also had thought we had moved away from linking to the exact page with where a work starts in a digitized volume but I will update that for the relevant volumes and do that moving forward with the Appian files!

@AlisonBabeu AlisonBabeu merged commit 89d39ca into master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants