Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use work title not host title #289

Merged
merged 2 commits into from
Feb 19, 2019
Merged

use work title not host title #289

merged 2 commits into from
Feb 19, 2019

Conversation

balmas
Copy link
Contributor

@balmas balmas commented Feb 18, 2019

No description provided.

@ghost
Copy link

ghost commented Feb 18, 2019

Hook UI build recap

@lcerrato
Copy link
Contributor

@balmas
The way I have been regularizing labels is that the label for each edition or translation should match the book page for that work. Alternate titles are titles not labels.

@balmas
Copy link
Contributor Author

balmas commented Feb 19, 2019

ok, not sure I totally understand that, but if you don't agree with what I suggest here please feel free to reject it :-)

clarified edition and translation descriptions
@lcerrato
Copy link
Contributor

@balmas No problem. I am finding key biblio data is missing — like edition publishers and years and seeing info better suited to the catalog, like birth/death years. Just trying to provide consistent, brief info so that the user can immediately and briefly identify the source of the edition and doing it in a way that is as consistent as I can.

@lcerrato
Copy link
Contributor

note: I really dislike the Latin label here — I've never seen commonly used (Sermones is better).

@ghost
Copy link

ghost commented Feb 19, 2019

Hook UI build recap

@lcerrato lcerrato merged commit eaaaf21 into master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants