Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug due to a change in matrixStats ties.method= ordering #58

Closed
LTLA opened this issue Sep 8, 2019 · 2 comments
Closed

Bug due to a change in matrixStats ties.method= ordering #58

LTLA opened this issue Sep 8, 2019 · 2 comments

Comments

@LTLA
Copy link
Contributor

LTLA commented Sep 8, 2019

Due to HenrikBengtsson/matrixStats@0e70e46, the DelayedMatrixStats rowRanks generic's defaults for ties.method is not interacting well withmatrixStats::rowRanks.

library(matrixStats)
X <- rbind(sample(10, 20, replace=TRUE))

DelayedMatrixStats::rowRanks(X, ties.method="average")
rank(X[1,], ties.method="average")

DelayedMatrixStats::rowRanks(X, ties.method="min")
rank(X[1,], ties.method="min")

DelayedMatrixStats::rowRanks(X, ties.method="max")
rank(X[1,], ties.method="max")

This is causing scran CHECK failures.

Session info
R version 3.6.0 Patched (2019-05-02 r76458)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.3 LTS

Matrix products: default
BLAS:   /home/luna/Software/R/R-3-6-branch-dev/lib/libRblas.so
LAPACK: /home/luna/Software/R/R-3-6-branch-dev/lib/libRlapack.so

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8    
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8   
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] matrixStats_0.55.0

loaded via a namespace (and not attached):
 [1] BiocManager_1.30.4       compiler_3.6.0           Matrix_1.2-17           
 [4] IRanges_2.19.14          parallel_3.6.0           DelayedArray_0.11.4     
 [7] tools_3.6.0              S4Vectors_0.23.21        grid_3.6.0              
[10] DelayedMatrixStats_1.7.1 BiocGenerics_0.31.5      BiocParallel_1.19.2     
[13] stats4_3.6.0             lattice_0.20-38         
@LTLA
Copy link
Contributor Author

LTLA commented Sep 8, 2019

The problem disappears upon reinstallation of DelayedMatrixStats, probably because the S4 method tables are only updated during reinstallation. Suggest bumping version numbers on both release and devel versions to prompt reinstallation of DMS in user machines.

@PeteHaitch
Copy link
Owner

Thanks, Aaron.
I synced the rowRanks() signatures with matrixStats v0.55.0 (and made that the minimum supported version for DelayedMatrixStats), and bumped the version number in release and devel.
Hopefully all goes smoothly in the next build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants