Fix bug where uninitialised value of list was accessed; remember, C++…

… is zero-indexed!
PeteHaitch · Apr 25, 2015 · 9162c8b · 9162c8b
1 parent 178e48b
commit 9162c8b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,8 +1,8 @@
 Package: methsim
 Type: Package
 Title: An R package to simulate DNA methylation data
-Version: 0.5.0.9012
-Date: 2015-04-24
+Version: 0.5.0.9013
+Date: 2015-04-25
 Author: Peter Hickey <peter.hickey@gmail.com>
 Maintainer: Peter Hickey <peter.hickey@gmail.com>
 Description: methsim is software to simulate DNA methylation sequencing data.

diff --git a/src/simulateZ.cpp b/src/simulateZ.cpp
@@ -66,11 +66,11 @@ Rcpp::List simulatez(IntegerVector fh,
   // TODO: Check that all elements of P have the identical and proper
   // dimensions.
   // The below only checks the first element has the proper nrow.
-  if (MarginalProb.nrow() != P[1].nrow()) {
+  if (MarginalProb.nrow() != P[0].nrow()) {
     Rcpp::stop("length(marginalProb) != nrow(P[[1]])");
   }
   // Make sure we don't try to access out of bounds elements of P.
-  if (max(fh + nh - 1) > P[1].nrow()) {
+  if (max(fh + nh - 1) > P[0].nrow()) {
     Rcpp::stop("max(fh + nh - 1) > nrow(P)");
   }