Bug/config fix #118
Closed
Bug/config fix #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Guest Mode Switch
Remove NoOne sensor and added renamed DummySwitch to GuestModeSwitch
Anyone sensor is now mandatory
Add Switch Check
Switch was initialized in wrong order
this.platform.storage NOT this.storage
GuestModeSwitch state now accessible from getStateFromCache()
Read switch state and affect PeopleAllAccessory
Merry Christmas! I got a new Mac Mini this year and wanted to try to add MAC address support. With the help of SonarLint, I was able to refactor the code. I hope you like it 😄 I've adapted the code from https://github.com/stickpin/homebridge-people-arp in my own special implementation.
Why: - I recently moved from HOOBS to Homebridge (for reasons) and had to reinstall the plugin. It had been so long I didn't realize there was now a way to graphically set parameters! How: - Using the tool at https://hamidihamza.com/ajsf/?framework=bootstrap-4 I was able to build the config.schema.json file. Test Plan: - Deploy it! I hope nothing breaks and people continue to enjoy using this plugin.
Adding Configuration Schema
Why: - An empty people config was not handled. - People is 9/10 empty because it's just been installed. How: - If config["people"] is empty set the value to an empty array i.e. [] instead. Test Plan: - Ship it!
Handle New install
|
Mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.