Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: set_temperature service call can set the wrong temperature #212

Closed
PeteRager opened this issue Nov 16, 2022 · 0 comments · Fixed by #208
Closed

BUG: set_temperature service call can set the wrong temperature #212

PeteRager opened this issue Nov 16, 2022 · 0 comments · Fixed by #208
Labels
bug Something isn't working
Projects

Comments

@PeteRager
Copy link
Owner

Describe the bug
When this climate service call is called with a requested hvac_mode that is not the current hvac_mode and the system is not in single setpoint mode, the wrong setpoint will be issued.

For example, if the systemMode is Heat and the service call requests Cool and 72; the systemMode will be changed to Cool and the HeatSetpoint will be set to 72. The correct behavior is the set the Cool Setpoint to 72.

To Reproduce
Found during automated unit testing

Expected behavior
The correct behavior is the set the Cool Setpoint to 72.

Screenshots/Logs
If applicable, add screenshots to help explain your problem.

Version

  • Home Assistant: all
  • This Integration: all

**Integration Configuration **

  • Cloud or Local Connection:
  • Inverter or Sensor Diagnostics Enabled:

Additional context
Add any other context about the problem here.

@PeteRager PeteRager changed the title set_temperature service call can set the wrong temperature BUG: set_temperature service call can set the wrong temperature Nov 16, 2022
PeteRager added a commit that referenced this issue Nov 16, 2022
pylint + improve unit test coverage
@PeteRager PeteRager added this to Done in 2022.11.0 Nov 16, 2022
@PeteRager PeteRager linked a pull request Nov 18, 2022 that will close this issue
@PeteRager PeteRager added the bug Something isn't working label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant