Some updates for Dockerfile that also fix gnuplot deps. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tightens up the Dockerfile a little by: - removing some unneeded layers in the build step. This cuts about 200mbs off the image. - added the gnuplot lib from the testing repo. This allows png generation in tsdb - added the `/tmp` dir to the Volume declation. This prevents unknowing users from writing pngs to union fs. - moved the hbase download link to archive.apache.org which is more longterm.
|
nice! |
|
Thank you very much for this PR; it should build in the docker hub within the next hour or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I was working on some Bosun stuff locally and I was using this box for local development. I noticed that png generation was messed up so I dove in to try and fix that. #11 Ran into a few issues. Here is a summery of some of the changes in this pull request.
/tmpdir to the Volume declaration. This prevents unknowing users from writing pngs to union fs.I noticed that there was already a request for some Dockerfile updates so if these changes are already in the pipeline that is totally fine but there were a few issues that I wanted to bring your your attention. 1 The install section of the tsdb makefile is broken on alpine. I think you are aware of this because you just run tsdb from the build directory. Just wanted to cross link the issue here OpenTSDB/opentsdb#707 .
Secondly I noticed that the version of go-dnsmasq slipped a little in the
janeczku/alpine-kubernetes:3.2docker box. It causes issues because you have to add an additional flag to get this box running on boxes without a search domain defined. I put some comments here janeczku/docker-alpine-kubernetes#9 just to get it all documented.I would love to help get a strong community version of a docker with tsdb with hbase running in it. Let me know how I can help. And thanks for all your work so far.