tpm: tpm_deprecated.c fix compare #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how it worked so far... but it seems like it is a mistake. |
|
ping? |
Compiling with a recent GCC fails as follows:
tpm-emulator/tpm/tpm_cmd_handler.c: In function ‘tpm_setup_rsp_auth’:
tpm-emulator/tpm/tpm_cmd_handler.c:3332:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
tpm_hmac_final(&hmac, rsp->auth2->auth);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tpm-emulator/tpm/tpm_cmd_handler.c:3333:5: note: here
case TPM_TAG_RSP_AUTH1_COMMAND:
Looking at the code, this does indeed seem unintentional. Add a break
state in the appropriate place.
Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
|
dup of #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tpm/tpm_deprecated.c:437:7: error: ‘__builtin_memcmp_eq’ reading 20 bytes from a region of size 8 [-Werror=stringop-overflow=]
if (memcmp(&b1, &newAuthLink, sizeof(TPM_HMAC))) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Bug: https://bugs.gentoo.org/show_bug.cgi?id=664198