Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rustoc comments in #[derive(FromRepr)] #276

Merged
merged 1 commit into from Jul 3, 2023
Merged

Handle rustoc comments in #[derive(FromRepr)] #276

merged 1 commit into from Jul 3, 2023

Conversation

smoelius
Copy link
Contributor

I think this fixes #275, but please scrutinize.

@smoelius
Copy link
Contributor Author

It looks like the same failures occurred on master, so I assume they are not caused by this change: https://ci.appveyor.com/project/Peternator7/strum/builds/47333125

Please let me know if that is not correct.

@Peternator7
Copy link
Owner

Hey @smoelius, thanks for tackling this. I'll take a closer look at the logic, but what immediately jumps out is that let-else is too new a feature for strum. It's great for brevity for sure, but for back-compat, we'll need to use an if let {} else {} to not break older rust versions.

I also have a PR to fix the CI to the proper msrv. After that merges, you should be able to rely on the builds again. Sorry about that.

@smoelius
Copy link
Contributor Author

smoelius commented Jul 1, 2023

let-else is too new a feature for strum.

🤦 This should have occurred to me, given #261 (comment).

@Peternator7 Peternator7 merged commit 93ea44d into Peternator7:master Jul 3, 2023
1 check passed
Peternator7 pushed a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

derive(FromRepr) broken in 0.25.0
2 participants