PSFConvolvedModel2D and Upgrades to Modeling
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robelgeda
added
Enhancement
|
Reminder to push changes to |
robelgeda
changed the title
PSFConvolvedImageModelPSFConvolvedImageModel and Upgrades to Modeling
robelgeda
added
Documentation
|
I've taken a look and run through the code. I'm able to reproduce the notebooks, and I like leaving the PSFModel in there for the time being but with the deprecation warning. Setting up the infrastructure to follow the astropy directory structrue make sense and hopefully will make it easier to move some things upstream |
crawfordsm
approved these changes
Mar 26, 2022
robelgeda
changed the title
PSFConvolvedImageModel and Upgrades to ModelingPSFConvolvedModel2D and Upgrades to Modeling
|
Thank you @crawfordsm! I will merge once tests pass. Also I did a minor last minute update, I renamed |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements:
close #57
close #55
close #99
Bug fixes:
fixes #20
fixes #87
fixes #105
fixes #106
This PR introduces upgrades to and deprecates the
PSFModelclass by introducing thePSFConvolvedModel2Dclass (model). This PR also moves the fitting code to a modeling folder according to #99. Deprecation warning has been added toPSFModelbut it has not been removed. I will be removed in the next version of the code (likelyv0.5, see ticket #102).For #87, I exposed the Astropy weights parameter in
petrofit.modeling.fitting.fit_modelso users can pass fitting weights using rms images. I have added this to the docs as well.