Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenSersic2D and bug fixes #145

Merged
merged 5 commits into from
Aug 20, 2022
Merged

GenSersic2D and bug fixes #145

merged 5 commits into from
Aug 20, 2022

Conversation

robelgeda
Copy link
Contributor

@robelgeda robelgeda commented Aug 20, 2022 •
edited

closes #141

This PR adds:

  • Add regions to requirements.
  • Add GenSersic2D model, which is a Sersic model with generalized ellipse isophot (boxy) parameter.
  • Bug Fix: Model attribute bug fix in PSFConvolvedModel2D (Bug: accessing PSFConvolvedModel2D.model edits the PSFConvolvedModel2D itself).
  • Print out PSF sum if it is not equal to 1.

@robelgeda robelgeda added the Enhancement New feature or request label Aug 20, 2022
@robelgeda robelgeda merged commit ed966ea into PetroFit:main Aug 20, 2022
@robelgeda robelgeda mentioned this pull request Aug 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PSF Normalization Warnning Should Say Sum
1 participant
@robelgeda