Merge pull request #35 from PetrochukM/general

Small Updates
PetrochukM · May 6, 2018 · a68497e · a68497e
2 parents 1766cc3 + 875f61e
commit a68497e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/torchnlp/download.py b/torchnlp/download.py
@@ -121,7 +121,7 @@ def _get_filename_from_url(url):
 
 
 def download_file_maybe_extract(url, directory, filename=None, extension=None, check_files=[]):
-    """ Download the file at ``url`` to ``directory``.
+    """ Download the file at ``url`` to ``directory``. Extract to ``directory`` if tar or zip.
 
     Args:
         url (str): Url of file.
@@ -181,7 +181,7 @@ def _check_download(*filepaths):
 
 
 def download_files_maybe_extract(urls, directory, check_files=[]):
-    """ Download the files at ``urls`` to ``directory``.
+    """ Download the files at ``urls`` to ``directory``. Extract to ``directory`` if tar or zip.
 
     Args:
         urls (str): Url of files.

diff --git a/torchnlp/word_to_vector/pretrained_word_vectors.py b/torchnlp/word_to_vector/pretrained_word_vectors.py
@@ -171,6 +171,8 @@ def cache(self, name, cache, url=None):
             self.vectors = torch.Tensor(vectors).view(-1, dim)
             self.dim = dim
             logger.info('Saving vectors to {}'.format(path_pt))
+            if not os.path.exists(cache):
+                os.makedirs(cache)
             torch.save((self.itos, self.stoi, self.vectors, self.dim), path_pt)
         else:
             logger.info('Loading vectors from {}'.format(path_pt))