Make sure returncode is actually returned properly

Pext · Mar 23, 2017 · 5b8fd65 · 5b8fd65
1 parent 7cbdcd9
commit 5b8fd65
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/pext/__main__.py b/pext/__main__.py
@@ -471,16 +471,22 @@ def _pip_install(self, module_dir_name: str) -> int:
             # Probably already exists, that's okay
             pass
 
-        return run([sys.executable,
-                    '-m',
-                    'pip',
-                    'install',
-                     '--system',
-                     '--upgrade',
-                     '--target',
-                     module_dependencies_path,
-                     '-r',
-                     module_requirements_path]).returncode
+        try:
+            run([sys.executable,
+                 '-m',
+                 'pip',
+                 'install',
+                  '--system',
+                  '--upgrade',
+                  '--target',
+                  module_dependencies_path,
+                  '-r',
+                  module_requirements_path], check=True)
+
+        except CalledProcessError as e:
+            return e.returncode
+
+        return 0
 
     def bind_logger(self, logger: Logger) -> str:
         """Connect a logger to the module manager.