Skip to content

Commit

Permalink
Replace pep257 by pydocstyle (#485)
Browse files Browse the repository at this point in the history
  • Loading branch information
airvzxf committed Oct 31, 2022
1 parent 28dd753 commit a3602a6
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 15 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ jobs:
# Operative systems: [ubuntu-18.04, ubuntu-20.04, ubuntu-22.04]
# The Ubuntu version 22.04 has problems with Linux script to deploy plugin conda.
OPERATIVE_SYSTEM: [ubuntu-18.04]
# Python versions: ["3.6", "3.7", "3.8", "3.9", "3.10"]
# The Python versions 3.6 has problems with QT.
# The Python versions 3.10 has problems with Tox Travis.
PYTHON_VERSION: ["3.9"]
# Python versions: ["3.6", "3.7", "3.8", "3.9", "3.10", "3.11"]
# Python 3.6 has problems importing the requirement pyqt5==5.15.7.
PYTHON_VERSION: ["3.11"]
fail-fast: false
name: "${{ matrix.OPERATIVE_SYSTEM }} Python-${{ matrix.PYTHON_VERSION }} Portable-${{ matrix.PEXT_BUILD_PORTABLE }}"
runs-on: ${{ matrix.OPERATIVE_SYSTEM }}
Expand Down Expand Up @@ -55,9 +54,9 @@ jobs:
PEXT_BUILD_PORTABLE: [0]
# Operative systems: [macos-10.15, macos-11, macos-12]
OPERATIVE_SYSTEM: [macos-latest]
# Python versions: ["3.6", "3.7", "3.8", "3.9", "3.10"]
# The Python versions 3.6 and 3.10 are not working correctly.
PYTHON_VERSION: ["3.9"]
# Python versions: ["3.6", "3.7", "3.8", "3.9", "3.10", "3.11"]
# Python 3.6 has problems importing the requirement pyqt5==5.15.7.
PYTHON_VERSION: ["3.11"]
fail-fast: false
name: "${{ matrix.OPERATIVE_SYSTEM }} Python-${{ matrix.PYTHON_VERSION }} Portable-${{ matrix.PEXT_BUILD_PORTABLE }}"
runs-on: ${{ matrix.OPERATIVE_SYSTEM }}
Expand Down
4 changes: 2 additions & 2 deletions pext/ui_qt5.py
Original file line number Diff line number Diff line change
Expand Up @@ -1557,7 +1557,7 @@ def __init__(self, main_loop_queue: Queue, window: 'Window') -> None:
listener.start()

def on_press(self, key) -> bool:
"""Executed when a key is pressed."""
"""Track pressed keys and show window when all keys for the global hotkey are pressed."""
if key is None:
return True

Expand All @@ -1572,7 +1572,7 @@ def on_press(self, key) -> bool:
return True

def on_release(self, key) -> bool:
"""Executed when a key is released."""
"""Remove key from pressed keys list on release."""
try:
self.modifiers.remove(key)
except KeyError:
Expand Down
8 changes: 2 additions & 6 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,18 @@
# test suite on all supported python versions. To use it, "pip install tox"
# and then run "tox" from this directory.

[tox]
# 3.5 is the lowest supported versions
envlist = py35, py36, py37

[testenv]
passenv = DISPLAY
commands =
flake8 pext/ pext_dev/__main__.py test/
mypy --ignore-missing-imports --follow-imports=skip pext/
mypy --ignore-missing-imports --follow-imports=skip pext_dev/__main__.py
pep257 pext/ pext_dev/__main__.py
pydocstyle pext/ pext_dev/__main__.py
python test/test.py
deps =
flake8
mypy
pep257
pydocstyle
types-setuptools
types-requests

Expand Down

0 comments on commit a3602a6

Please sign in to comment.