Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wallet connect #108

Merged
merged 14 commits into from Apr 11, 2022
Merged

refactor: wallet connect #108

merged 14 commits into from Apr 11, 2022

Conversation

kingsleydon
Copy link
Collaborator

@kingsleydon kingsleydon commented Apr 7, 2022

Allowing selecting wallets among Polkadot{.js}, Talisman and SubWallet.

#19 #17 should be fixed along

@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for app-phala-network ready!

Name Link
🔨 Latest commit 672b520
🔍 Latest deploy log https://app.netlify.com/sites/app-phala-network/deploys/6253eb52b7c7760009537e05
😎 Deploy Preview https://deploy-preview-108--app-phala-network.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kingsleydon kingsleydon self-assigned this Apr 7, 2022
@kingsleydon kingsleydon merged commit 26c55e9 into master Apr 11, 2022
@kingsleydon kingsleydon deleted the wallet-select branch April 11, 2022 08:55
@zozyo
Copy link

zozyo commented Apr 11, 2022

Unable to connect wallet using imToken app after this merge

@h4x3rotab
Copy link
Contributor

Unable to connect wallet using imToken app after this merge

I thought it was never supported?

@zozyo
Copy link

zozyo commented Apr 11, 2022

Unable to connect wallet using imToken app after this merge

I thought it was never supported?

It was supported for sure.

Tutorial on the forum.
https://forum.phala.network/t/topic/3438

I successfully tested it half a day ago, before this merge.

@h4x3rotab
Copy link
Contributor

Interesting. We talked to imtoken many times to add the support to Khala, and finally it's addressed. Let's try to fix it.

@h4x3rotab
Copy link
Contributor

@zozyo Please don't forget to ask for a tip once the bug is fixed

@zozyo
Copy link

zozyo commented Apr 11, 2022

Interesting. We talked to imtoken many times to add the support to Khala, and finally it's addressed. Let's try to fix it.

20220412004931
20220412004934

imToken seems has Polkadot{.js} installed, but not work after this merge.

@zozyo
Copy link

zozyo commented Apr 12, 2022

@zozyo Please don't forget to ask for a tip once the bug is fixed

Tip asked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants