Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ChainBridge and BridgeTransfer pallets to FRAME v2 #419

Closed
h4x3rotab opened this issue Aug 23, 2021 · 11 comments · Fixed by #422
Closed

Upgrade ChainBridge and BridgeTransfer pallets to FRAME v2 #419

h4x3rotab opened this issue Aug 23, 2021 · 11 comments · Fixed by #422
Labels
bounty-m Mid-size Bounty attached bounty-paid Bounty paid good first issue Good for newcomers help wanted Extra attention is needed
Projects

Comments

@h4x3rotab
Copy link
Contributor

FRAMEv2: https://substrate.dev/docs/en/knowledgebase/runtime/pallets#frame-v2

Substrate has upgraded its FRAME (module framework) to v2 in the past year. However we still have two pallets written in v1 syntax. We should upgrade them to v2.

For Bounty Hunters

  • Deliverables
    1. A PR to upgrade pallets/{birdge,bridge_transfer} to FRAMEv2
    2. Pass all the unit tests. (Bonus: increase the test coverage as much as possible!)
  • Resources
    • To build the project, install llvm-10, clang-10 or above. Then run cargo build --release. We use rust nightly-2021-05-11.
    • To get the unit test coverage, run ./scripts/coverage-pallets.sh
@h4x3rotab h4x3rotab created this issue from a note in Backlog (Bugfix / XS Features) Aug 23, 2021
@h4x3rotab h4x3rotab added bounty-m Mid-size Bounty attached good first issue Good for newcomers help wanted Extra attention is needed labels Aug 23, 2021
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 14.302 DOT (400.03 USD @ $27.97/DOT) attached to it as part of the Phala-Network fund.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month from now.
Please review their action plans below:

1) bernardoaraujor has started work.

  • upgrade bridge pallet to FRAME v2
  • upgrade bridge_transfer pallet to FRAME v2
  • check unit tests

Learn more on the Gitcoin Issue Details page.

@h4x3rotab
Copy link
Contributor Author

@bernardoaraujor FYI: There's already one submission. He is too fast 😅

@bernardoaraujor
Copy link
Contributor

@bernardoaraujor FYI: There's already one submission. He is too fast sweat_smile

Thanks for letting me know.
I haven't made much progress yet so I'll leave this one to @vinhbhn

@h4x3rotab let me know in case you still need another PR and I'll get back to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 14.302 DOT (363.13 USD @ $25.15/DOT) has been submitted by:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 14.302 DOT (376.14 USD @ $26.39/DOT) has been submitted by:

  1. @vinhbhn

@h4x3rotab please take a look at the submitted work:


@h4x3rotab h4x3rotab linked a pull request Aug 26, 2021 that will close this issue
@h4x3rotab
Copy link
Contributor Author

Thanks for the contribution. Because of the wallet problem in Gitcoin.co, I will just send the token to your wallet directly.

Are you willing to get notification the next time when we announce some new bounties? I'd also love to chat to hear more from you.

@h4x3rotab
Copy link
Contributor Author

@h4x3rotab h4x3rotab added the bounty-paid Bounty paid label Aug 26, 2021
Backlog automation moved this from Bugfix / XS Features to Done Aug 26, 2021
@vinhbhn
Copy link
Contributor

vinhbhn commented Aug 26, 2021

Thanks for the contribution. Because of the wallet problem in Gitcoin.co, I will just send the token to your wallet directly.

Are you willing to get notification the next time when we announce some new bounties? I'd also love to chat to hear more from you.

Yes, please send me a notification when there is a new bounty. I will try to finish it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 months ago.
Please review their action plans below:

1) flipchan has started work.

Hey,
I'm ready to start on this. I have worked for various substrate based projects before and I'm more then happy to do this!

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 14.302 DOT (452.52 USD @ $30.31/DOT) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty-m Mid-size Bounty attached bounty-paid Bounty paid good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants