Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Password is not strong enough" is not an easily actionable error message. #174

Closed
KairuByte opened this issue Aug 15, 2023 · 1 comment
Closed
Labels
🪲 bug Something isn't working 🎛️ server There are things to do on the server

Comments

@KairuByte
Copy link

KairuByte commented Aug 15, 2023

Describe the bug
"Password is not strong enough" is not an easily actionable error message.

To Reproduce
Steps to reproduce the behavior:
Attempt to create a user account with the password 12345678

Expected behavior
Password requirements be shown to explain to the user what needs to change with their password to be accepted.

Additional context
Not 100% certain this is server side, but I believe the error message comes from the server.

@KairuByte KairuByte added 🎛️ server There are things to do on the server 🪲 bug Something isn't working labels Aug 15, 2023
@Alfagun74
Copy link
Contributor

This originates from here https://github.com/typestack/class-validator/blob/c3d561c469a09b6620fc8f96cade888b9087dd16/src/decorator/string/IsStrongPassword.ts#L37

Fixed in the next GV version.

Alfagun74 added a commit that referenced this issue Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working 🎛️ server There are things to do on the server
Projects
Archived in project
Development

No branches or pull requests

2 participants