Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] All Users in permissionstab are VIPs instead of Regulars #2654

Closed
TheBlackHawk1337 opened this issue Jan 25, 2022 · 8 comments · Fixed by #2816
Closed

[Bug] All Users in permissionstab are VIPs instead of Regulars #2654

TheBlackHawk1337 opened this issue Jan 25, 2022 · 8 comments · Fixed by #2816
Assignees
Labels
Projects
Milestone

Comments

@TheBlackHawk1337
Copy link

PhantomBot Version: 3.5.0.10
Web Browser Version (if Panel related): 1.5.1

Detailed Description:
All users are shown as VIPs.
But with chat command "!permission username" the right permission is shown (f.ex. subscriber)

Screenshots (if applicable):
image
image

@Psychoboy
Copy link
Contributor

This issue is more drastic, if you do the Subscriber/VIP swap subscribers become VIP then

@gmt2001
Copy link
Member

gmt2001 commented Jan 25, 2022

Pretty sure this is a visual issue

@gmt2001 gmt2001 self-assigned this Jan 25, 2022
@gmt2001 gmt2001 added the bug label Jan 25, 2022
@gmt2001 gmt2001 added this to Needs triage in Bug Triage via automation Jan 25, 2022
@gmt2001 gmt2001 added this to the 3.5.1 milestone Jan 25, 2022
@gmt2001 gmt2001 moved this from Needs triage to Low priority in Bug Triage Jan 25, 2022
@Psychoboy
Copy link
Contributor

I tested this with !permission against another and they for sure were NOT vip and it returned VIP. Also functions set to VIP was letting subscribers execute even though I had it set to VIP is higher then SUB

@gmt2001
Copy link
Member

gmt2001 commented Jan 25, 2022

Checked the permissions display. The OP is a visual issue due to the Permissions page on the panel not handling the Subscriber/VIP Swap flag

Psychoboy seems to be having a separate issue

@Psychoboy
Copy link
Contributor

Psychoboy commented Jan 25, 2022

I think I found the problem, well in my case anyways. If the VIPSwap is enabled. in the DB the command is set to value of 3 instead of 5 for permission. in commandRegister it swaps them again so now the VIP is back to 5 instead of 3. then in customCommand it goes down to case 5 and it gets approved for a sub instead of being restricted it if it was VIP only

@Psychoboy
Copy link
Contributor

my issue may be separate but noticed it while looking at the original reported issue

gmt2001 added a commit to gmt2001/PhantomBot-1 that referenced this issue Jan 25, 2022
Bug Triage automation moved this from Low priority to Closed Jan 26, 2022
@TheBlackHawk1337
Copy link
Author

[REOPEN]

I upgraded to Version 3.5.0.11 (stable) (Revision: b390b31). Now all entrys showing "Subscribers" instead of "VIPs", but this is not true either.

I filtered by "Regulars" and there are only 4 entries, all of which are ex-mods where I set the permission manually.
Filtering by "viewers" does not show any matching entries.

I tested a random "subscriber" with /user in chat and that user is not currently a subscriber. And the bot gives out that he has VIP Permissions:
image
("Vorher 2 Monate abonniert" means Subscribed 2 months before. The user is currently not a Sub)
image
image
All Screenshots are with same user.

@TheBlackHawk1337
Copy link
Author

In Addition: When i reload the permissions page the permissions are randomly switch between "VIPs" and "Subscribers". Most time shows "VIPs".

I have the Sub/VIP swap option on.

@gmt2001 gmt2001 reopened this Feb 16, 2022
Bug Triage automation moved this from Closed to Needs triage Feb 16, 2022
@gmt2001 gmt2001 modified the milestones: 3.5.1, 3.5.2 Feb 22, 2022
@gmt2001 gmt2001 modified the milestones: 3.6.1, 3.7.0 Apr 21, 2022
Bug Triage automation moved this from Needs triage to Closed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Bug Triage
  
Closed
Development

Successfully merging a pull request may close this issue.

3 participants