[Security Issue] Adjust pubKeyHash b/c it overlaps with an Ark chain #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An existing Ark chain, Persona.im, already uses the same pubKeyHash of 55, which will overlap your address space exactly. Shifting to a pubKeyHash of 56 retains addresses in the P... range and avoids conflict with Persona. idxDec: 55 idxHex: 0x37 min: P8bB9yPr3vVByqfmM5KXftyGckAtAdu6f8 max: PXvn95h8m6x4oGorNVerA2F4FFRpmMwCyw idxDec: 56 idxHex: 0x38 min: PXvn95h8m6x4oGorNVerA2F4FFRpqMqwAM max: PwGP8BzRUHQwchwwPuzAe9WqskgmTLNx8F
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An existing Ark chain, Persona.im, already uses the same pubKeyHash of 55, which will overlap your address space exactly.
Shifting to a pubKeyHash of 56 retains addresses in the P... range and avoids conflict with Persona.
idxDec: 55
idxHex: 0x37
min: P8bB9yPr3vVByqfmM5KXftyGckAtAdu6f8
max: PXvn95h8m6x4oGorNVerA2F4FFRpmMwCyw
idxDec: 56
idxHex: 0x38
min: PXvn95h8m6x4oGorNVerA2F4FFRpqMqwAM
max: PwGP8BzRUHQwchwwPuzAe9WqskgmTLNx8F