Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: add missing ReturnTypeWillChange attributes #2

Merged
merged 1 commit into from
Jan 14, 2023
Merged

bugfix: add missing ReturnTypeWillChange attributes #2

merged 1 commit into from
Jan 14, 2023

Conversation

oxidmod
Copy link

@oxidmod oxidmod commented Jan 13, 2023

Some methods need ReturnTypeWillChange attributes

Result of php vendor/bin/phpunit without changes

PHP Deprecated:  Return type of Pharaonic\DotArray\DotArray::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ...
PHP Deprecated:  Return type of Pharaonic\DotArray\DotArray::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ...

@MoamenEltouny MoamenEltouny merged commit a557390 into Pharaonic:main Jan 14, 2023
@MoamenEltouny
Copy link
Member

Thank you @oxidmod for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxidmod @MoamenEltouny