Adds the Name parameter to the Variable section of a nested prefab in…

…stance #282
PhaserEditor2D · May 16, 2023 · c8aba01 · c8aba01
1 parent cc97994
commit c8aba01
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 7 deletions.
diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -9,6 +9,7 @@
 * Auto computes the middle-private nested prefabs. It doesn't require to declare a parent of a nested prefab as nested prefab. 
 * Improves Outline elements tagging. It uses tahs like `#prefab_inst` `#nested_prefab_inst` `#scope_local` `#scope_nested_prefab`... So you can search for it in the Outline filter box.
 * Allows enabling input in objects.
+* Adds the Name parameter to the Variable section of a nested prefab instance.
 
 ## v3.60.3 - Apr 27, 2023
 

diff --git a/source/editor/plugins/phasereditor2d.scene/src/core/code/SceneCodeDOMBuilder.ts b/source/editor/plugins/phasereditor2d.scene/src/core/code/SceneCodeDOMBuilder.ts
@@ -639,7 +639,7 @@ namespace phasereditor2d.scene.core.code {
 
         private addCreateObjectCodeOfNestedPrefab(obj: ISceneGameObject, createMethodDecl: MethodDeclCodeDOM, lazyStatements: CodeDOM[]) {
 
-            const varname = this.getPrefabInstanceVarName(obj);
+            const varname = SceneCodeDOMBuilder.getPrefabInstanceVarName(obj);
 
             const result = this.buildSetObjectProperties({
                 obj,
@@ -687,7 +687,7 @@ namespace phasereditor2d.scene.core.code {
                     && objParent === this._scene.getPrefabObject();
 
                 parentVarName = parentIsPrefabObject ? "this"
-                    : this.getPrefabInstanceVarName(objParent);
+                    : SceneCodeDOMBuilder.getPrefabInstanceVarName(objParent);
             }
 
             // the script nodes require using the varname of the parents
@@ -881,7 +881,7 @@ namespace phasereditor2d.scene.core.code {
                 .join(" & ");
         }
 
-        private getPrefabInstanceVarName(obj: ISceneGameObject): string {
+        static getPrefabInstanceVarName(obj: ISceneGameObject): string {
 
             const objES = obj.getEditorSupport();
 
@@ -904,7 +904,7 @@ namespace phasereditor2d.scene.core.code {
             return varName;
         }
 
-        private findPrefabInstanceWhereTheGivenObjectIsDefined(obj: ui.sceneobjects.ISceneGameObject): ui.sceneobjects.ISceneGameObject {
+        private static findPrefabInstanceWhereTheGivenObjectIsDefined(obj: ui.sceneobjects.ISceneGameObject): ui.sceneobjects.ISceneGameObject {
 
             const objES = obj.getEditorSupport();
 
@@ -919,7 +919,7 @@ namespace phasereditor2d.scene.core.code {
             return this.findPrefabInstanceOfFile(parent, objPrefabFile);
         }
 
-        private findPrefabInstanceOfFile(obj: ISceneGameObject, targetPrefaFile: io.FilePath): ISceneGameObject {
+        private static findPrefabInstanceOfFile(obj: ISceneGameObject, targetPrefaFile: io.FilePath): ISceneGameObject {
 
             const finder = ScenePlugin.getInstance().getSceneFinder();
 

diff --git a/...editor2d.scene/src/ui/sceneobjects/object/properties/NestedPrefabObjectVariableSection.ts b/...editor2d.scene/src/ui/sceneobjects/object/properties/NestedPrefabObjectVariableSection.ts
@@ -19,8 +19,34 @@ namespace phasereditor2d.scene.ui.sceneobjects {
 
             const comp = this.createGridElement(parent, 2);
 
-            const { btn } = GameObjectVariableSection.createTypeEditor(this, comp);
-            btn.disabled = true;
+            {
+                // Name
+
+                this.createLabel(comp, "Name", "The name of the variable associated to this object. This name is used by the compiler.");
+
+                const text = this.createText(comp, true);
+
+                this.addUpdater(() => {
+
+                    text.value = this.flatValues_StringOneOrNothing(
+                        this.getSelection()
+                            .map(obj => this.getVarName(obj)));
+                })
+            }
+
+            {
+                // Type
+
+                const { btn } = GameObjectVariableSection.createTypeEditor(this, comp);
+                btn.disabled = true;
+            }
+        }
+
+        private getVarName(obj: ISceneGameObject) {
+
+            const varName = core.code.SceneCodeDOMBuilder.getPrefabInstanceVarName(obj);
+
+            return varName;
         }
 
         canEdit(obj: any, n: number): boolean {