Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor ENH to espei_script.py #244

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

Zhyrek
Copy link
Contributor

@Zhyrek Zhyrek commented Apr 5, 2023

Added support for single .json file to be checked:
- Previously, "espei --check-datasets datafolder/jsonfile.json" would return silently, because "datafolder/jsonfile.json" is not a folder
- Now, "espei --check-datasets datafolder/jsonfile.json" will check jsonfile.json, similarly to if you called "espei --check-datasets datafolder"

Added check that there is at least 1 .json file in the path specified
- Previously, "espei --check-datasets datafoldr" would return silently, because there are no json files at the misspelled, nonexistent "datafoldr" folder
- Now "espei --check-datasets datafoldr" will warn the user that there are no json files at the path, and maybe they have a typo

Added support for single .json file to be checked:
    - Previously, "espei --check-datasets datafolder/jsonfile.json" would return silently, because "datafolder/jsonfile.json" is not a folder
    - Now, "espei --check-datasets datafolder/jsonfile.json" will check jsonfile.json, similarly to if you called  "espei --check-datasets datafolder"

Added check that there is at least 1 .json file in the path specified
    - Previously, "espei --check-datasets datafoldr" would return silently, because there are no json files at the misspelled, nonexistent "datafoldr" folder
    - Now "espei --check-datasets datafoldr" will warn the user that there are no json files at the path, and maybe they have a typo
@bocklund bocklund merged commit 0ea63a7 into PhasesResearchLab:master Jun 28, 2023
@bocklund
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants