Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Germplasm call refinements #963

Merged
merged 2 commits into from
May 6, 2024
Merged

Germplasm call refinements #963

merged 2 commits into from
May 6, 2024

Conversation

bellerbrock
Copy link
Collaborator

@bellerbrock bellerbrock commented Apr 22, 2024

Description

Provide a summary of your changes including motivation and context.
If these changes fix a bug or resolves a feature request, be sure to link to that issue.

Addresses problems with germplasm retrieval breaking study imports. Makes germplasm detail object nullable to handle cases where /search/germplasm isn't implemented (BIMS) and adds a client-controlled paging check to prevent endless requests when server paging has errors (Deltabreed).

closes #962
closes #954

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated relevant documentation

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.

Improved germplasm retrieval during study imports

@trife trife requested a review from chaneylc April 22, 2024 19:12
@trife trife merged commit 6b5e37a into main May 6, 2024
1 check passed
@trife trife deleted the germplasm_call_refinements branch May 6, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add try/catch to germplasm brapi calls when getting studies Fields not uploading Via BrAPI[BUG]:
3 participants